-
Notifications
You must be signed in to change notification settings - Fork 82
Rewrite the introduction to the Clustering section #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can improve this image, in my opinion it is quite noisy with labelling every database with either primary or secondary. What do you think about having a legend that indicates what the colour means? It would declutter the image then.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also I prefer the 6 server image to the 10 server image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm being pedantic then messages 3/5 "data committed" are not technically correct. The followers respond with an acknowledgement that they have appended the transaction to their raft log. Once the writer has received a quorum the transaction is considered committed to raft. We likely don't want to expose the internals of raft here, so my suggestion would be to change the response messages to "data replicated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll update the diagram