fix(multisig-factory): Resolve bug where child account isn't receiving deposit#236
Open
fix(multisig-factory): Resolve bug where child account isn't receiving deposit#236
Conversation
frol
reviewed
Oct 23, 2024
Contributor
There was a problem hiding this comment.
Looks great to me, I have a small suggestion and once that is addressed, we can merge it
@race-of-sloths invite
🙁 This repository is not a part of the Race of SlothsPlease ask the maintainer to contact us to join the race! What is the Race of Sloths
Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! |
Author
|
@frol good advice, thank you |
Author
|
Proof that bringing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded
near-sdkto 5.3.0 as the old version 2.0.0 caused a bug whereenv::attached_deposit()call always returned zeroLeading to

LackBalanceFormStateerror on the child accountExample of Transaction BEFORE The Fix
https://testnet.nearblocks.io/txns/3hAThdBV5sk9DurAdJKJe5igYLv6myAMK4zGNj6ankA9
Example of Transaction AFTER The Fix
https://testnet.nearblocks.io/txns/3sgM3RY2PeCKSB3umGc1cbnYSwsgnrNzx5dGXcxsrsFL