Add support for no_annotations to OpenCage geocoder#265
Open
js62789 wants to merge 3 commits intonchaulet:mainfrom
Open
Add support for no_annotations to OpenCage geocoder#265js62789 wants to merge 3 commits intonchaulet:mainfrom
js62789 wants to merge 3 commits intonchaulet:mainfrom
Conversation
js62789
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning on making a significant number of requests to OpenCage's geocoding service, and it's recommended that we pass
no_annotations=1so that we can speed up response times and minimize payloads by excluding [annotations](urlhttps://opencagedata.com/api#annotations) data.
I've added tests and checked the linter. In the process I realized that2 of the MapQuest geocoder tests are failing and the VirtualEarth geocoder creates linter warnings. Those were preexisting issues and were unaffected by my changes, but I took the liberty of fixing those as well so that these changes comply with the contributor guidelines.