Fix #72 + Fix #206, Correct iteration bug in TO_LAB_RemoveAllCmd#211
Open
thnkslprpt wants to merge 1 commit intonasa:mainfrom
Open
Fix #72 + Fix #206, Correct iteration bug in TO_LAB_RemoveAllCmd#211thnkslprpt wants to merge 1 commit intonasa:mainfrom
TO_LAB_RemoveAllCmd#211thnkslprpt wants to merge 1 commit intonasa:mainfrom
Conversation
c5c8c34 to
fa234df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
SubEntryinTO_LAB_RemoveAllCmd()#206SubEntry, which caused theTO_LAB_RemoveAllCmdcommand try to to unsubscribe from the same entryTO_LAB_MAX_SUBSCRIPTIONStimesTesting performed
Tested with local cFS build to confirm prior and post-fix behavior is as described above.
Expected behavior changes
App will correctly iterate through the subs table now.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt