Skip to content

Fix #181, correct off-by-one error in CI_LAB_ReadUpLink #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thnkslprpt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #181, correct off-by-one error in CI_LAB_ReadUpLink #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsw/src/ci_lab_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ void CI_LAB_ReadUpLink(void)
CFE_Status_t CfeStatus;
CFE_SB_Buffer_t *SBBufPtr;

for (i = 0; i <= CI_LAB_MAX_INGEST_PKTS; i++)
for (i = 0; i < CI_LAB_MAX_INGEST_PKTS; i++)
{
if (CI_LAB_Global.NetBufPtr == NULL)
{
Expand Down
10 changes: 0 additions & 10 deletions fsw/src/ci_lab_app.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,6 @@ void CI_LAB_ReadUpLink(void);
/* Global State Object */
extern CI_LAB_GlobalData_t CI_LAB_Global;

/*
* Individual message handler function prototypes
*
* Per the recommended code pattern, these should accept a const pointer
* to a structure type which matches the message, and return an int32
* where CFE_SUCCESS (0) indicates successful handling of the message.
*/
int32 CI_LAB_Noop(const CI_LAB_NoopCmd_t *data);
int32 CI_LAB_ResetCounters(const CI_LAB_ResetCountersCmd_t *data);

/* Housekeeping message handler */
int32 CI_LAB_ReportHousekeeping(const CFE_MSG_CommandHeader_t *data);

Expand Down
2 changes: 0 additions & 2 deletions fsw/src/ci_lab_eds_dispatch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ void CI_LAB_TaskPipe(const CFE_SB_Buffer_t *SBBufPtr)
CFE_SB_MsgId_t MsgId;
CFE_Status_t Status;

CFE_MSG_GetMsgId(&SBBufPtr->Msg, &MsgId);

Status = EdsDispatch_CI_LAB_Application_Telecommand(SBBufPtr, &CI_LAB_TC_DISPATCH_TABLE);

if (Status != CFE_SUCCESS)
Expand Down
Loading