Fix #1543, Rename CFE_TIME_QueryResetVars to CFE_TIME_RestoreFromTimeResetVars#2497
Open
thnkslprpt wants to merge 1 commit intonasa:mainfrom
Open
Fix #1543, Rename CFE_TIME_QueryResetVars to CFE_TIME_RestoreFromTimeResetVars#2497thnkslprpt wants to merge 1 commit intonasa:mainfrom
CFE_TIME_QueryResetVars to CFE_TIME_RestoreFromTimeResetVars#2497thnkslprpt wants to merge 1 commit intonasa:mainfrom
Conversation
…romTimeResetVars`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CFE_TIME_QueryResetVars(void) | ||
| void CFE_TIME_RestoreFromTimeResetVars(void) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long
| * | ||
| *-----------------------------------------------------------------*/ | ||
| void CFE_TIME_QueryResetVars(void) | ||
| void CFE_TIME_RestoreFromTimeResetVars(void) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_TIME_QueryResetVarsmisnomer #1543CFE_TIME_QueryResetVarstoCFE_TIME_RestoreFromTimeResetVarsgiven that the function does not just 'query' the time variables, but rather it actually uses them to restore and set theCFE_TIME_ReferenceState_tmembers (or initialize from scratch if there is no valid reset data).Note: Could also go with
CFE_TIME_RestoreFromResetVars(not including the extraTimequalifier in the name) but that may be less clear given the current names of the reset variables:cFE/modules/core_private/fsw/inc/cfe_es_resetdata_typedef.h
Lines 79 to 88 in 7f5ebcd
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt