Skip to content

Open Source Draco Release#466

Merged
dzbaker merged 1 commit intomainfrom
draco-integration
Jan 22, 2026
Merged

Open Source Draco Release#466
dzbaker merged 1 commit intomainfrom
draco-integration

Conversation

@dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Jan 15, 2026 •
edited
Loading

NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"

Batch update of latest cFS software release

Reflects commit 4589155d61cf2540c335d3495b836fe4677c2b03 from NASA internal development repo

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 15, 2026
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 15, 2026
View reviewed changes
fsw/inc/cfe_psp.h
#define PSP_DEBUG(...) PSP_DEBUG_LEV(1, __VA_ARGS__)
#else
/* Debug printfs are not compiled in at all */
#define PSP_DEBUG_LEV(l, ...)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro PSP_DEBUG_LEV(l,__VA_ARGS__...) is variadic, and hence not allowed.
fsw/inc/cfe_psp.h
#else
/* Debug printfs are not compiled in at all */
#define PSP_DEBUG_LEV(l, ...)
#define PSP_DEBUG(...)

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro PSP_DEBUG(__VA_ARGS__...) is variadic, and hence not allowed.
fsw/modules/endian_api/cfe_psp_endian_common.c
CFE_PSP_MODULE_DECLARE_SIMPLE(endian_api);

/* Note these are not supposed to be exposed publicly but UT needs to access them */
uint8_t CFE_PSP_ENDIAN_INDICATOR;

Check notice

Code scanning / CodeQL

Global could be static Note

The global variable CFE_PSP_ENDIAN_INDICATOR is not accessed outside of cfe_psp_endian_common.c and could be made static.
fsw/modules/endian_api/cfe_psp_endian_common.c
return (CFE_PSP_ENDIAN_INDICATOR == CFE_PSP_LITTLE_INDICATOR);
}

void CFE_PSP_ReportEndian(uint8 CheckValue)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/modules/endian_api/cfe_psp_endian_impl.h
*/
#include "cfe_psp_endian.h"

#define ENDIAN_CONVERSION_COMBINE_NAME(ns, f) ns##_##f

Check notice

Code scanning / CodeQL

Undisciplined macro Note

The macro ENDIAN_CONVERSION_COMBINE_NAME(ns,f) uses token pasting and is not allowed.
fsw/modules/endian_api/cfe_psp_endian_wrappers.c

/* When compiled with _UNIT_TEST_, this changes the names of the functions
* to allow multiple different implementations to be tested together */
#ifdef _UNIT_TEST_

Check notice

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.
fsw/pc-linux/src/cfe_psp_memory.c
/*
** External Declarations
*/
#ifdef __riscv

Check notice

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.
@jphickey jphickey force-pushed the draco-integration branch 3 times, most recently from c6eac8c to 16a0036 Compare January 22, 2026 22:04
@jphickey
NASA Docket No. GSC-19,200-1, and identified as "cFS Draco"
0b4796e 
Batch update of latest cFS software release

Reflects commit 4589155d61cf2540c335d3495b836fe4677c2b03 from NASA internal development repo
@jphickey jphickey marked this pull request as ready for review January 22, 2026 22:17
@dzbaker dzbaker merged commit 623fc3e into main Jan 22, 2026
9 of 10 checks passed
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jphickey jphickey jphickey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dzbaker @jphickey