-
Notifications
You must be signed in to change notification settings - Fork 15
demo(ensapi.openapi): include Name Tokens API in openapi.json
#1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Installs `hono-openapi` - Updates `validate.ts` to use `validator` from `hono-openapi` - Adds response zod schemas to ensnode-sdk - Adds `describeRoute` to resolution endpoints - Adds `GET /openapi.json` route
The Hono OpenAPI implementation with Zod produces a JSON schema where `z.undefined()` is [unrepresentable](https://zod.dev/json-schema#unrepresentable). This commit refactors the `NameTokensRequest` type and by consequence update the zod schema to pass. In order for OpenAPI JSON schema to work we cannot have any instances of unrepresentable APIs, and this so far was the only case.
Updates relevant zod schemas with a feature flag that allows the schema caller to decide if it needs to be made of fully serializable values, or not.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Applied this directly into #1338; thank you!! 🙏 |
|
What should be the next steps on this PR in relation to PR 1338? |
Updates relevant zod schemas with a feature flag that allows the schema caller to decide if it needs to be made of fully serializable values, or not.