Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
uses: mxenabled/path-tools/.github/workflows/ci.yml@master
with:
force: ${{ inputs.force != '' && inputs.force }}
java-version: '8'
java-version: '11'
skip-dependency-checks: true
55 changes: 29 additions & 26 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
import org.jetbrains.kotlin.gradle.dsl.JvmTarget

plugins {
id "com.github.mxenabled.coppuccino" version "3.2.1"
id "com.github.mxenabled.coppuccino" version "4.4.2"
id "groovy"
id "java"
id "maven-publish"
id "java-gradle-plugin"
id "org.jetbrains.kotlin.jvm" version "1.6.10"
id "org.jetbrains.kotlin.jvm" version "2.1.0"
}

group "com.mx.vogue"
version "1.0.3" // x-release-please-version
sourceCompatibility = 1.8
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11

repositories {
mavenCentral()
Expand All @@ -19,22 +22,16 @@ repositories {
}

dependencies {
implementation "org.apache.bcel:bcel:[6.6.0,7.0[" // Security update
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
implementation "org.apache.bcel:bcel:[6.11.0,7.0[" // Security update
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:2.1.0"
implementation "com.google.code.gson:gson:[2.0,3.0["
implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.3"
implementation "com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin:0.42.0"
implementation "com.github.spotbugs:spotbugs-annotations:4.7.2" // For annotating classes and methods to suppress SpotBugs violations

constraints {
implementation ("com.thoughtworks.xstream:xstream:1.4.19") { because "It resolves a bajillion CVEs" }
}
//upgrade to 2.15.0 after snakeyaml2
implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.3"
implementation "com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin:0.53.0"
implementation "com.github.spotbugs:spotbugs-annotations:4.9.8" // For annotating classes and methods to suppress SpotBugs violations

// Unit tests
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:[5.8.0,5.9.0["
testImplementation "org.junit.jupiter:junit-jupiter-api:[5.8.0,5.9.0["
testImplementation "org.mockito:mockito-inline:[4.0,5.0["
testImplementation "org.spockframework:spock-core:2.2-M1-groovy-3.0"
api "org.mockito:mockito-inline:[4.0,5.0["
api "org.spockframework:spock-core:2.4-M6-groovy-3.0"
}

gradlePlugin {
Expand All @@ -50,33 +47,39 @@ gradlePlugin {
}
}

compileKotlin {
kotlinOptions {
jvmTarget = "1.8"
} }
kotlin {
compilerOptions {
jvmTarget = JvmTarget.JVM_11
}
}

compileTestKotlin {
kotlinOptions {
jvmTarget = "1.8"
} }
jvmTarget = "11"
}
}

coppuccino {
kotlin { enabled = true }
coverage {
minimumCoverage = 0.70
minimumCoverage = 0.73
excludes = [
"com/mx/vogue/core/models/**"
]
}
}

sourceSets {
test { groovy { srcDirs "src/test/groovy" } }
test {
groovy {
srcDirs "src/test/groovy"
}
}
}

test { useJUnitPlatform() }

wrapper {
gradleVersion = "7.4.1"
gradleVersion = "7.6.3"
distributionType = Wrapper.DistributionType.ALL
}
255 changes: 126 additions & 129 deletions gradle.lockfile

Large diffs are not rendered by default.

Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-all.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
18 changes: 14 additions & 4 deletions gradlew

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions gradlew.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ pluginManagement {
}
}

rootProject.name = "vogue"
rootProject.name = "vogue"
2 changes: 1 addition & 1 deletion src/main/kotlin/com/mx/vogue/VoguePlugin.kt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import org.gradle.api.Project
import org.gradle.api.logging.LogLevel

class VoguePlugin : Plugin<Project> {
@Suppress("MaxLineLength")
@Suppress("ktlint:standard:max-line-length")
override fun apply(project: Project) {
var dependenciesExtension = project.extensions.create("vogue", VogueDependenciesExtension::class.java)

Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/com/mx/vogue/core/ReportRenderer.kt
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ private fun buildUpgradeMessages(dependencyContexts: List<DependencyContext>, bu
}
}

@Suppress("MaxLineLength")
@Suppress("ktlint:standard:max-line-length")
private fun buildWarningUpgradeMessage(dependencyContext: DependencyContext): String {
return " - ${yellow(getPackage(dependencyContext.versionsPluginDependency))} [${green(dependencyContext.current.toString())} -> ${green(dependencyContext.latest.toString())}]\n"
}

@Suppress("MaxLineLength")
@Suppress("ktlint:standard:max-line-length")
private fun buildErrorUpgradeMessage(dependencyContext: DependencyContext): String {
return " - ${red(getPackage(dependencyContext.versionsPluginDependency))} [${green(dependencyContext.current.toString())} -> ${green(dependencyContext.latest.toString())}]\n"
}
6 changes: 3 additions & 3 deletions src/main/kotlin/com/mx/vogue/core/ReportUtils.kt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/
@file:Suppress("TooManyFunctions")

package com.mx.vogue.core

import com.mx.vogue.core.exceptions.VogueProcessingException
Expand Down Expand Up @@ -51,7 +52,6 @@ fun getPackage(versionsPluginDependency: VersionsPluginDependency): String {
return "${versionsPluginDependency.group}:${versionsPluginDependency.name}"
}

@SuppressFBWarnings("BC_BAD_CAST_TO_ABSTRACT_COLLECTION")
fun getPackageRule(versionsPluginDependency: VersionsPluginDependency, packageRules: List<PackageRule>): PackageRule? {
return packageRules.firstOrNull {
Regex(it.`package`).containsMatchIn(getPackage(versionsPluginDependency))
Expand All @@ -76,7 +76,7 @@ fun filterStaleSuppressions(packageRules: List<PackageRule>?): List<PackageRule>
}.toList()
}

@Suppress("MaxLineLength")
@Suppress("ktlint:standard:max-line-length")
fun reportStaleSuppressions(packageRules: List<PackageRule>?) {
if (packageRules == null) {
return
Expand All @@ -101,7 +101,7 @@ fun reportStaleSuppressions(packageRules: List<PackageRule>?) {
}
}

@Suppress("MaxLineLength", "ThrowsCount", "ReturnCount")
@Suppress("ktlint:standard:max-line-length", "ThrowsCount", "ReturnCount")
fun shouldSuppressPackageRule(packageRule: PackageRule?): Boolean {
if (packageRule == null) {
return false
Expand Down
6 changes: 4 additions & 2 deletions src/main/kotlin/com/mx/vogue/core/VersionNumber.kt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import org.gradle.internal.impldep.com.google.common.base.Objects
import org.gradle.internal.impldep.com.google.common.collect.Ordering
import java.util.Locale

@Suppress("MaxLineLength")
@Suppress("ktlint:standard:max-line-length")
class VersionNumber private constructor(val major: Int, val minor: Int, val micro: Int, val patch: Int, val qualifier: String?, private val scheme: AbstractScheme) : Comparable<VersionNumber?> {
constructor(major: Int, minor: Int, micro: Int, qualifier: String?) : this(major, minor, micro, 0, qualifier, DEFAULT_SCHEME)
constructor(major: Int, minor: Int, micro: Int, patch: Int, qualifier: String?) : this(major, minor, micro, patch, qualifier, PATCH_SCHEME)
Expand All @@ -47,7 +47,9 @@ class VersionNumber private constructor(val major: Int, val minor: Int, val micr
}
return if (patch != other.patch) {
patch - other.patch
} else Ordering.natural<Comparable<*>>().nullsLast<Comparable<*>?>().compare(toLowerCase(qualifier), toLowerCase(other.qualifier))
} else {
Ordering.natural<Comparable<*>>().nullsLast<Comparable<*>?>().compare(toLowerCase(qualifier), toLowerCase(other.qualifier))
}
}

override fun equals(other: Any?): Boolean {
Expand Down
2 changes: 1 addition & 1 deletion src/test/groovy/com/mx/vogue/core/ConfigUtilsTest.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ class ConfigUtilsTest extends Specification {

defaultConfig.packageRules[1].package == "com.mx.*"
}
}
}