Conversation
ichristen
requested review from
cassie-song,
ebersin,
mmsutula and
ponagehl2
Collaborator
Author
|
@ebersin @ponagehl2 @mmsutula @cassie-song @sophiaOnPoint could one of you review this? Otherwise, I'll steal Maddie's computer and approve it by force :P. Reviews can be as simple as "I don't understand what this bit of code is doing, please comment more" or "Clean this up more" using the github comment feature. |
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
ebersin
reviewed
Oct 5, 2021
mmsutula
reviewed
Oct 5, 2021
mmsutula
reviewed
Oct 6, 2021
mmsutula
reviewed
Oct 6, 2021
mmsutula
reviewed
Oct 6, 2021
mmsutula
reviewed
Oct 6, 2021
mmsutula
reviewed
Oct 6, 2021
…d be cleaned up and moved. Arduino class for servo control from servo branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a meta Imaging module which reads images from other Imaging modules and performs QR detection upon them. This convolutional QR algorithm is sufficiently fast for realtime imaging. Working reliably on RoMi, will test on other systems. Future work might involve generalizing this algorithm to other QR shapes and dimensions.