Create multi-stage Dockerfile for easy builds#98
Open
todaywasawesome wants to merge 3 commits intomunnerz:masterfrom
Open
Create multi-stage Dockerfile for easy builds#98todaywasawesome wants to merge 3 commits intomunnerz:masterfrom
todaywasawesome wants to merge 3 commits intomunnerz:masterfrom
Conversation
munnerz
reviewed
Jun 12, 2020
Owner
munnerz
left a comment
munnerz
left a comment
There was a problem hiding this comment.
This looks great, and certainly makes builds easier 😄 could you remove the codefresh specific changes here for now? We don't currently have a CI system set up, but I think we're more likely to use something like GitHub actions as it saves having to configure additional external services 😄
Author
|
@munnerz PR updated to remove the files you didn't want. Should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just what the title says. The multi-stage part means we use separate containers for the build and the "runtime" so to speak. This way we can keep the image nice and small.
This also makes building the app very easy because you just need the Dockerfile, whereas before it relies on the user building the binary in the same directory as the binary.
You can see the image built here: https://hub.docker.com/r/todaywasawesome/kube-plex