Add Environmental Value and Advertise LB IP if specified#45
Open
angryninja48 wants to merge 2 commits intomunnerz:masterfrom
Open
Add Environmental Value and Advertise LB IP if specified#45angryninja48 wants to merge 2 commits intomunnerz:masterfrom
angryninja48 wants to merge 2 commits intomunnerz:masterfrom
Conversation
munnerz
reviewed
Jan 24, 2019
| {{- end }} | ||
| {{- if and (.Values.service.loadBalancerIP) (eq .Values.service.type "LoadBalancer") }} | ||
| - name: ADVERTISE_IP | ||
| value: "http://{{ .Values.service.loadBalancerIP }}:32400" |
Owner
There was a problem hiding this comment.
In order to make it possible to use TLS, this var needs to be set to a hostname instead of an IP.
It may be better if we simply expose setting ADVERTISE_IP to some arbitrary value via the values.yaml file instead of requiring using the services IP address.
Author
There was a problem hiding this comment.
Had the same thought - The user could just pass it in via the env value if they wanted to override it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.