Option to verify uniqueness of cleaned IDs (route, stop, trip, service) #22
Conversation
mmathieum
commented
Nov 28, 2025
mmathieum
commented
- Option to verify uniqueness of cleaned IDs (route, stop, trip, service) #20
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for verifying the uniqueness of cleaned IDs for services, routes, trips, and stops. The implementation is mostly correct and follows the existing patterns in the codebase.
My main concerns are:
- A potential
NullPointerExceptioninDefaultAgencyToolsdue to missing null checks, which could cause runtime failures. - The new verification logic in
MVerify.ktis highly repetitive and could be significantly simplified and improved for better error reporting.
I've provided specific suggestions to address these points. Additionally, the pattern of adding maps and methods for each ID type in DefaultAgencyTools is also quite repetitive, which is a minor maintainability concern you might want to address in the future.
There was a problem hiding this comment.
Pull request overview
This PR adds optional verification to ensure that cleaned IDs (service, route, trip, and stop IDs) remain unique after cleanup transformations are applied. The verification is opt-in and only runs when cleanup regex patterns are configured, with an additional option to explicitly allow non-unique IDs.
Key Changes:
- Introduced a new
MVerifyclass that checks for duplicate cleaned IDs and throws an error if duplicates are found - Added tracking maps to store original-to-cleaned ID mappings for all four ID types
- Added configuration options to explicitly allow non-unique IDs when needed
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| MVerify.kt | New verification utility that checks cleaned ID uniqueness across service, route, trip, and stop IDs |
| GAgencyTools.java | Added interface methods for uniqueness verification flags |
| RouteConfig.kt | Added configuration flags to allow non-unique route, trip, and stop IDs |
| AgencyConfig.kt | Added configuration flag to allow non-unique service IDs |
| DefaultAgencyTools.java | Implemented ID tracking maps, verification methods, and integrated verification into the generation process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
