News provider config #13
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new, standardized mechanism for news content providers to expose their internal configuration details. By defining new interfaces and a dedicated content provider URI, it enables external components to retrieve structured information about how each news feed is configured, including properties like target, language, color, severity, and noteworthy duration. This change enhances the discoverability and manageability of news sources within the application.
Highlights
- Content Provider Integration: Added a new
CONFIGURI constant (555) and corresponding query handling inNewsProviderto allow external components to retrieve news provider configurations via aCursor. - Specific Provider Implementations: Updated
TwitterNewsProviderandYouTubeNewsProviderto implement the newgetNewsConfig()method, providing detailed, structured configuration for their respective news feeds. Other providers likeCaSTOProvider,InstagramNewsProvider,RSSNewsProvider, andWinnipegTransitProviderreceived default or empty implementations. - Refactoring: Performed minor refactoring in
TwitterNewsProviderandYouTubeNewsProviderto useforEachIndexedfor iterating over news sources and streamlined color passing inTwitterNewsProvider's news reading logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a new configuration mechanism for news providers, allowing for more flexible and detailed news feed settings. This includes new interfaces (ProviderConfig, NewsProviderConfig, NewsFeedConfig) and their implementations for Twitter and YouTube, along with updates to the NewsProviderContract and ContentProviderConstants. The changes also include necessary URI matching and query handling in NewsProvider.java. However, the getNewsConfig() method in InstagramNewsProvider.kt, RSSNewsProvider.java, and WinnipegTransitProvider.java are left empty, which will cause compilation errors. These methods should return a DefaultNewsProviderConfig instance to ensure proper functionality and compilation.
Cursorfromnews://configCursor