feat(payments-next): subscriptionRenewalReminder-content-charge uses hard-coded English values for subscription interval #19989
+127
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-ilina
force-pushed
the
PAY-3497-subscription-renewal-reminder-content-charge-uses-hard-coded-english-values-for-subscription-interval
branch
from
3c6b11c to
dacf001
Compare
…hard-coded English values for subscription interval Because: * The subscriptionRenewalReminder-content-charge fluent string has a variable hardcoded in English, so a localized string will display with a mix of English and translated text. This commit: * Updates the string for proper localization and to match existing subscription plan lengths (daily, weekly, monthly, halfyearly (6-monthly), yearly. * Updates the string to break out the charge to show the tax amount (where applicable). - TODO Closes #[PAY-3497](https://mozilla-hub.atlassian.net/browse/PAY-3497)
elizabeth-ilina
force-pushed
the
PAY-3497-subscription-renewal-reminder-content-charge-uses-hard-coded-english-values-for-subscription-interval
branch
from
dacf001 to
0860dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3497
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
With tax:
No Tax:
Other information (Optional)
Any other information that is important to this pull request.