fix(webchannel): Send 'can_link_account' on email-first for isSync/isFirefoxNonSync when fxa_status resolves#19987
Conversation
…FirefoxNonSync when fxa_status resolves Because: * On email-first, we are sending 'can_link_account' before the fxa_status result has resolved, which tells us whether that Firefox supports sending the UID in can_link_account. This is problematic because we should NOT be sending the merge warning at this point if Firefox does support the UID capability This commit: * Sets the default of 'supportsCanLinkAccountUid' to 'undefined' until fxa_status is received, and does not auto-submit the email on email-first if 'supportsCanLinkAccountUid' is undefined fixes FXA-13002
LZoog
changed the title
vpomerleau
approved these changes
Feb 5, 2026
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
I had a bit of a tough time reproducing the issue with the STR in the main branch - the only way I was able to trigger the merge warning when it shouldn't be called was by manually changing the URL to return to the index page after signing in to sync. Signing out from sync that starting a new sign in from the browser toolbar did not trigger a merge warning.
However - the STR that I used did not trigger a merge warning in your branch, so this + code LGTM.
Side note, interesting to see that deleting the account then recreating with the same email does trigger a merge warning now that the uid is used (instead of email) to verify if merge is possible. 👍 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
fixes FXA-13002
Please reproduce first in Nightly, then switch into my branch and test in Nightly and in Release. You shouldn't see the merge warning for either Firefox when signing into the same account.