feat(settings): create ButtonPasskeySignin component #19986
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * we need a new button component for passkey sign in This commit: * creates ButtonPasskeySignin Closes FXA-12906
Contributor
Author
|
The loading icon is a bit off-center, so I'm waiting on UX for a centered asset. Otherwise ready for review |
bcolsson
requested changes
Feb 3, 2026
| ## ButtonPasskeySignin | ||
|
|
||
| button-passkey-signin = Sign in with Passkey | ||
| button-passkey-signin-loading = Securely signing in... |
Contributor
There was a problem hiding this comment.
Suggested change
| button-passkey-signin-loading = Securely signing in... | |
| button-passkey-signin-loading = Securely signing in… |
Should use the ellipsis character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12906
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Default:
Disabled:
Loading:
Other information (Optional)
Any other information that is important to this pull request.