Feature/sdk 75 support vault v2 market adapter in sdk #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oumar-fall
force-pushed
the
feature/sdk-75-support-vault-v2-market-adapter-in-sdk
branch
2 times, most recently
from
b93e7b0 to
0428e8a
Compare
Rubilmax
reviewed
Dec 17, 2025
packages/blue-sdk-viem/contracts/vault-v2/GetVaultV2MorphoMarketV1AdapterV2.sol
Outdated
Show resolved
Hide resolved
tarikbellamine
left a comment
tarikbellamine
left a comment
There was a problem hiding this comment.
what do you think about trying to restrict the devx of using the old adapter without removing it completely? im thinking deprecation tags, JS docs discouraging it, etc
oumar-fall
force-pushed
the
feature/sdk-75-support-vault-v2-market-adapter-in-sdk
branch
from
0428e8a to
5d99239
Compare
Collaborator
Author
I'm not sure about this, the sdk is read-only so we don't decide which type of adapter is being used |
Foulks-Plb
reviewed
Dec 18, 2025
packages/blue-sdk/src/vault/v2/VaultV2MorphoMarketV1AdapterV2.ts
Outdated
Show resolved
Hide resolved
Foulks-Plb
approved these changes
Dec 19, 2025
Rubilmax
approved these changes
Dec 19, 2025
oumar-fall
deleted the
feature/sdk-75-support-vault-v2-market-adapter-in-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.