-
Notifications
You must be signed in to change notification settings - Fork 4
implement multi–branch #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 6fc97ce.
NotNite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having multi-branch support, but I'm worried about the migration process, especially since it'd require everyone to repatch.
migration is already handled. the installer can still patch and unpatch previous versions, and it can read the previous on–disk format for metadata |
But the path where moonlight releases get installed to would change, yes? This wouldn't interact well with Moonbase, especially if the client needs to repatch itself while it's running. |
yeah, hence why the "moonlight" checkbox in the roadmap is not checked. i'm working on it |
…cal files are out of sync with version info metadata file
update: |
|
that should be the end of this patchset. only blocker is my open moonlight pr which needs more testing |
|
fixes some environment specific bugs and makes it much more sane as well |
|
here's a flatpak if you wanna test locally: https://files.slonk.ing/xeTauGy4.ml.flatpak to build yourself, clone https://github.com/flathub/io.github.moonlight_mod.moonlight-installer and follow instructions there |
|
i've been using this branch on my main machine since it was drafted and i haven't come across any bugs. if there are no other issues left to address, can this be merged?
|
let people have multiple installations of moonlight & pick which one gets used for which discord installation
roadmap