Skip to content

Conversation

@slonkazoid
Copy link
Contributor

@slonkazoid slonkazoid commented Aug 9, 2025

let people have multiple installations of moonlight & pick which one gets used for which discord installation

roadmap

@slonkazoid slonkazoid requested a review from NotNite August 9, 2025 23:48
Copy link
Member

@NotNite NotNite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of having multi-branch support, but I'm worried about the migration process, especially since it'd require everyone to repatch.

@slonkazoid
Copy link
Contributor Author

but I'm worried about the migration process, especially since it'd require everyone to repatch.

migration is already handled. the installer can still patch and unpatch previous versions, and it can read the previous on–disk format for metadata

@NotNite
Copy link
Member

NotNite commented Aug 11, 2025

migration is already handled. the installer can still patch and unpatch previous versions, and it can read the previous on–disk format for metadata

But the path where moonlight releases get installed to would change, yes? This wouldn't interact well with Moonbase, especially if the client needs to repatch itself while it's running.

@slonkazoid
Copy link
Contributor Author

migration is already handled. the installer can still patch and unpatch previous versions, and it can read the previous on–disk format for metadata

But the path where moonlight releases get installed to would change, yes? This wouldn't interact well with Moonbase, especially if the client needs to repatch itself while it's running.

yeah, hence why the "moonlight" checkbox in the roadmap is not checked. i'm working on it

@slonkazoid
Copy link
Contributor Author

slonkazoid commented Aug 13, 2025

migration is already handled. the installer can still patch and unpatch previous versions, and it can read the previous on–disk format for metadata

But the path where moonlight releases get installed to would change, yes? This wouldn't interact well with Moonbase, especially if the client needs to repatch itself while it's running.

yeah, hence why the "moonlight" checkbox in the roadmap is not checked. i'm working on it

update:

@slonkazoid slonkazoid marked this pull request as ready for review August 13, 2025 16:11
@slonkazoid
Copy link
Contributor Author

that should be the end of this patchset. only blocker is my open moonlight pr which needs more testing

@slonkazoid
Copy link
Contributor Author

fixes some environment specific bugs and makes it much more sane as well

@slonkazoid
Copy link
Contributor Author

here's a flatpak if you wanna test locally: https://files.slonk.ing/xeTauGy4.ml.flatpak

to build yourself, clone https://github.com/flathub/io.github.moonlight_mod.moonlight-installer and follow instructions there

@slonkazoid
Copy link
Contributor Author

slonkazoid commented Dec 9, 2025

i've been using this branch on my main machine since it was drafted and i haven't come across any bugs. if there are no other issues left to address, can this be merged?

one improvement i want to make is tooltips for disabled elements and why they're disabled, as i've confused even myself with that once 😅 nvm im stupid this is already a thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants