Add customChatButtons

[Enovale]

No description provided.

[NotNite]

Sorry for the long wait on this PR, I've been on vacation for the past few weeks. I can't extensively review or test this just yet, but here's some quick observations:

• You should be importing your other Webpack modules with something like @moonlight-mod/wp/customChatButtons_settings, instead of directly importing the files, because this will bundle the file multiple times. You can do something like this for types.
• This export name doesn't seem stable: https://github.com/Enovale/moonlight-extensions/blob/adc5c64a56ee51ed733197c959658a96be7d5af9/src/customChatButtons/webpackModules/entrypoint.tsx#L20

Again, apologies for the wait!

[Enovale]

I should have addressed both these things? Please let me know if my solutions are done correctly

[NotNite]

Hi, sorry for the long wait! Please make sure the commit is updated in the build manifest so I can review this PR again. Thanks!

[Enovale]

Sorry, I updated the build commit.

[NotNite]

Tested this and it works well:

However, I have some more observations to make:

• The natives are implemented in an insecure way, which can allow for arbitrary file read on the host. I was able to read /etc/passwd by simply writing moonlight.getNatives("customChatButtons").getImageData("/etc/passwd", (r) => console.log(atob(r.data.split("base64,").pop()))); I'd suggest adding some filtering - we work around this in the CSS extension by checking the file extension and only reading paths that are saved in the config file (instead of providing an arbitrary path in the function argument). Alternatively, maybe restrict images to a certain folder, like path.join(moonlightNode.getMoonlightDir(), "customChatButtons").
• The tagline of this extension isn't immediately obvious on what it does, as it just says it's a port from Equicord. I'd suggest mentioning the custom buttons that can send preset messages there.
• These two dependencies still aren't declared: https://github.com/Enovale/moonlight-extensions/blob/218dd4bab8d03f8c6f1dc20e48f97de838c93d2a/src/customChatButtons/webpackModules/svgPickerModal.tsx#L19 and https://github.com/Enovale/moonlight-extensions/blob/218dd4bab8d03f8c6f1dc20e48f97de838c93d2a/src/customChatButtons/webpackModules/entrypoint.tsx#L11

[keysmashes]

drive-by comment: unless I'm missing something, path.join alone isn't sufficient to prevent directory traversal:

> path.join("/my/pictures/directory", "../../../etc/passwd")
'/etc/passwd'

[Enovale]

I screwed up my version control... oops.

[Enovale]

Nothing has changed, I just messed up my branch. Sorry for the confusion.