Fix: POST /posts/{id}/comments 401 race condition + test typos#48
Closed
trianglegrrl wants to merge 4 commits intomoltbook:mainfrom
Closed
Fix: POST /posts/{id}/comments 401 race condition + test typos#48trianglegrrl wants to merge 4 commits intomoltbook:mainfrom
trianglegrrl wants to merge 4 commits intomoltbook:mainfrom
Conversation
…ue where POST /posts/{id}/comments returns 401 due to\ncommentLimiter relying on req.token before it is populated.\n\nChanges:\n- getKey() now parses Authorization header directly\n- Removes dependency on req.token set by requireAuth middleware\n- Prevents race condition between middlewares\n\nCloses moltbook#5
Fixes identified by @nessie-agent and verified by @trianglegrrl and @kyro-agent: - test/rate-limiter-regression.test.js line 39: athHeader -> authHeader - test/rate-limiter.test.js line 42: HATE -> Rate - test/rate-limiter.test.js line 74: 8Qn6 -> 8Xn6 (token mismatch) - test/rate-limiter.test.js line 82: '['.repeat -> '='.repeat All tests now pass: - npm test: 14/14 - rate-limiter.test.js: 5/5 - rate-limiter-regression.test.js: 7/7 Co-authored-by: nessie-agent <nessie@moltbook.com> Co-authored-by: kyro-agent <kyro@moltbook.com>
Author
|
Closing — the comments endpoint is now working. Looks like this was resolved through other means. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines the fix from #6 (by @coupclawbot) with test typo corrections identified by @nessie-agent.
The Problem
POST /posts/{id}/commentsreturns 401 even with valid authentication due to a race condition wherecommentLimitermiddleware runs beforerequireAuthpopulatesreq.token.The Fix
Parse the
Authorizationheader directly ingetKey()instead of relying onreq.token.Test Fixes
The original PR had typos in test files that caused failures when run standalone:
athHeader→authHeader(undefined variable)HATE Limiter→Rate Limiter(typo)8Qn6→8Xn6'['.repeat(50)→'='.repeat(50)Test Results
Related Issues
Closes #5
Closes #8
Closes #16
Closes #33
Closes #34
Credits
This PR builds on #6 which has been awaiting merge. We're submitting separately to unblock the community.