Skip to content

Fix project dependencies search #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prospector merged 4 commits into from
Dec 19, 2025
+21 −5
Merged

Fix project dependencies search #4932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b420fd
add search on all project types except mod packs
tdgao Dec 19, 2025
2106827
add search by ID
tdgao Dec 19, 2025
d94fc8e
fix placeholder
tdgao Dec 19, 2025
be82daf
rename to dependency select
tdgao Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions ...-project-version/components/ModSelect.vue → ...t-version/components/DependencySelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
placeholder="Select project"
:options="options"
:searchable="true"
search-placeholder="Search by name, slug, or paste ID..."
search-placeholder="Search by name or paste ID..."
:no-options-message="searchLoading ? 'Loading...' : 'No results found'"
@search-input="(query) => handleSearch(query)"
:disableSearchFilter="true"
/>
</template>

Expand Down Expand Up @@ -34,10 +35,24 @@ const search = async (query: string) => {
const results = await labrinth.projects_v2.search({
query: query,
limit: 20,
facets: [['project_type:mod']],
facets: [
[
'project_type:mod',
'project_type:plugin',
'project_type:shader ',
'project_type:resourcepack',
'project_type:datapack',
],
],
})

options.value = results.hits.map((hit) => ({
const resultsByProjectId = await labrinth.projects_v2.search({
query: '',
limit: 20,
facets: [[`project_id:${query}`]],
})

options.value = [...resultsByProjectId.hits, ...results.hits].map((hit) => ({
label: hit.title,
value: hit.project_id,
icon: defineAsyncComponent(() =>
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/components/ui/create-project-version/stages/AddDependenciesStage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ import {
} from '@modrinth/ui'
import type { DropdownOption } from '@modrinth/ui/src/components/base/Combobox.vue'

import ModSelect from '~/components/ui/create-project-version/components/ModSelect.vue'
import ModSelect from '~/components/ui/create-project-version/components/DependencySelect.vue'
import { injectManageVersionContext } from '~/providers/version/manage-version-modal'

import AddedDependencyRow from '../components/AddedDependencyRow.vue'
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/src/components/base/Combobox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ const props = withDefaults(
triggerClass?: string
forceDirection?: 'up' | 'down'
noOptionsMessage?: string
disableSearchFilter?: boolean
}>(),
{
placeholder: 'Select an option',
Expand Down Expand Up @@ -244,7 +245,7 @@ const optionsWithKeys = computed(() => {
})

const filteredOptions = computed(() => {
if (!searchQuery.value || !props.searchable) {
if (!searchQuery.value || !props.searchable || props.disableSearchFilter) {
return optionsWithKeys.value
}

Expand Down