Make Maven file resolution case-insensitive #4917
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Maven resolves the dependency, it sends the
artifactIdas part of the.jarand.pomfile name in whatever case was specified for the dependency.The problem is that the file name is in the case that the user uploaded it (usually the same as their original
artifactId), and the.pomfile generated by modrinth is always lowercase. This means that unless yourartifactIdis in lowercase ONLY and the uploaded file is also only in lowercase, Modrinth will fail to serve the correct file.This PR changes the file name comparison to be case-insensitive.