Technical review queue #4775
Merged
Technical review queue #4775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Endpoint changes needed for frontend;
|
aecsocket
force-pushed
the
boris/tech-review-queue
branch
3 times, most recently
from
2cd1c61 to
c807076
Compare
IMB11
requested changes
Nov 22, 2025
Member
IMB11
left a comment
IMB11
left a comment
There was a problem hiding this comment.
- Need to provide
download_urlfor each file report - Broken url encoding for delphi downloading files
Contributor
Author
|
@clrxbl when this is deployed onto prod, the prod Delphi |
…inth away from issue types
fetchfern
requested changes
Dec 18, 2025
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Auth`] using the closure to create the message. | ||
| #[inline] | ||
| #[track_caller] |
Contributor
There was a problem hiding this comment.
These methods shouldn't panic so this isn't desirable
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Auth`] with the given message. | ||
| #[inline] | ||
| #[track_caller] |
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Request`] with the given message. | ||
| #[inline] | ||
| #[track_caller] |
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Request`] using the closure to create the message. | ||
| #[inline] | ||
| #[track_caller] |
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Internal`] with the given message. | ||
| #[inline] | ||
| #[track_caller] |
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`ApiError::Internal`] using the closure to create the message. | ||
| #[inline] | ||
| #[track_caller] |
apps/labrinth/src/util/error.rs
Outdated
|
|
||
| /// Maps the error variant into an [`eyre::Report`] with the given message. | ||
| #[inline] | ||
| #[track_caller] |
fetchfern
approved these changes
Dec 19, 2025
* chore: fix typo in status message * feat(labrinth): overhaul malware scanner report storage and routes * chore: address some review comments * feat: add Delphi to Docker Compose `with-delphi` profile * chore: fix unused import Clippy lint * feat(labrinth/delphi): use PAT token authorization with project read scopes * chore: expose file IDs in version queries * fix: accept null decompiled source payloads from Delphi * tweak(labrinth): expose base62 file IDs more consistently for Delphi * feat(labrinth/delphi): support new Delphi report severity field * chore(labrinth): run `cargo sqlx prepare` to fix Docker build errors * tweak: add route for fetching Delphi issue type schema, abstract Labrinth away from issue types * chore: run `cargo sqlx prepare` * chore: fix typo on frontend generated state file message * feat: update to use new Delphi issue schema * wip: tech review endpoints * wip: add ToSchema for dependent types * wip: report issues return * wip * wip: returning more data * wip * Fix up db query * Delphi configuration to talk to Labrinth * Get Delphi working with Labrinth * Add Delphi dummy fixture * Better Delphi logging * Improve utoipa for tech review routes * Add more sorting options for tech review queue * Oops join * New routes for fetching issues and reports * Fix which kind of ID is returned in tech review endpoints * Deduplicate tech review report rows * Reduce info sent for projects * Fetch more thread info * Address PR comments * fix ci * fix ci * fix postgres version mismatch * fix version creation * Implement routes * feat: batch scan alert * feat: layout * feat: introduce surface variables * fix: theme selector * feat: rough draft of tech review card * feat: tab switcher * feat: batch scan btn * feat: api-client module for tech review * draft: impl * feat: auto icons * fix: layout issues * feat: fixes to code blocks + flag labels * feat: temp remove mock data * fix: search sort types * fix: intl & lint * chore: re-enable mock data * fix: flag badges + auto open first issue in file tab * feat: update for new routes * fix: more qa issues * feat: lazy load sources * fix: re-enable auth middleware * feat: impl threads * fix: lint & severity * feat: download btn + switch to using NavTabs with new local mode option * feat: re-add toplevel btns * feat: reports page consistency * fix: consistency on project queue * fix: icons + sizing * fix: colors and gaps * fix: impl endpoints * feat: load all flags on file tab * feat: thread generics changes * feat: more qa * feat: fix collapse * fix: qa * feat: msg modal * fix: ISO import * feat: qa fixes * fix: empty state basic * fix: collapsible region * fix: collapse thread by default * feat: rough draft of new process/flow * fix labrinth build * fix thread message privacy * New tech review search route * feat: qa fixes * feat: QA changes * fix: verdict on detail not whole issue * fix: lint + intl * fix: lint * fix: thread message for tech rev verdict * feat: use anim frames * fix: exports + typecheck * polish: qa changes * feat: qa * feat: qa polish * feat: fix malic modal * fix: lint * fix: qa + lint * fix: pagination * fix: lint * fix: qa * intl extract * fix ci --------- Signed-off-by: Calum H. <contact@cal.engineer> Co-authored-by: Alejandro González <me@alegon.dev> Co-authored-by: aecsocket <aecsocket@tutanota.com>
IMB11
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.