This repository was archived by the owner on Apr 8, 2025. It is now read-only.
doc: add await and fix param key name#267
Open
KelvinQiu802 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
doc: add await and fix param key name#267KelvinQiu802 wants to merge 1 commit intomodelcontextprotocol:mainfrom
KelvinQiu802 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
1. Add await for this.mcp.connect since it returns a Promise. 2. use inputSchema instead of input_schema (fix type)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awaitforthis.mcp.connectsince it returns a Promise.inputSchemainstead ofinput_schema(fix type)Motivation and Context
await, an error will occur when callinggetToolsbecause the connection has not been established yet.inputSchema, notinput_schema.How Has This Been Tested?
Fix and run it
Breaking Changes
no
Types of changes
Checklist
Additional context