[VLM] Add brand field to accuracy evaluation #2404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wangshangsam
suggested changes
Dec 6, 2025
Comment on lines
+128
to
+130
| if norm_truth == norm_pred: | ||
| matches.append(1) | ||
| continue |
Contributor
There was a problem hiding this comment.
I'm just wondering, if it's an exact match, wouldn't the score from fuzz.ratio be also bigger than valid_threshold? Therefore, maybe there's no need to treat the exact match as a special case (that needed to be handled differently)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I intent to add the brand field to the accuracy evaluation.
Since brand can be any string, I opted to use another package to perform the evaluation.
The library rapidfuzz helps compare strings and provide a numeric value based on a threshold. In comparisson using sklearn looks for exact string matches and If we have 1,000 different brands, sklearn treats this as a classification problem with 1,000 classes (multi-classification problem).
The evaluation now will look like this: