Trim file path from Kineto File name to avoid errors when running from another directory#182
Conversation
…m another directory
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Hi @spandoescode, |
768c878 to
a4a0ea2
Compare
|
Hey @JoongunPark, I've rebased the changes, and all the commits are now being passed. Could you please check? |
|
Hi @spandoescode, It seems you first merge the latest main branch into yours, and then send PR to main again. |
|
Hey @JoongunPark, The change that you're showing is the commit that was redone because merge of main into my branch. The final PR only contains the single line change for the file name. From my perspective, the PR was made from the latest main branch into main. Let me know if you think this is okay, or if I should try anything else. |
Hi, @spandoescode . Still, I see old commits (e.g., d3243d9) in your PR. @tushar-krishna @srinivas212 , this PR looks good to me. Could you please check? Thank you! Test result on my Envs. |
Summary
Using the chakra_trace_link command from a directory other than the one where the Kineto trace is stored raises an error. This is because the absolute file path is directly appended to the argument passed with --chakra-device-trace. The solution is to sanitize the input so that the --chakra-device-trace does not contain any path, just the base file name. This way, the chakra_trace_link command can be used from both the same directory as the Kineto file, as well as any other directory. This is a necessary change when traces from different devices/runs are stored in separate folders.
Test Plan