Bugfix/engine path dialog #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alle remotes entfernt, Um es in PgnBrowser zu entfernen wurde noch was in index.js hinzugefügt
idk if i´m stupid or git has problems rn but I can only push half of my changes
LuisW04
approved these changes
Dec 16, 2025
Collaborator
There was a problem hiding this comment.
Code is not very readable because of the lambda expressions, additional comments could be helpful
Collaborator
There was a problem hiding this comment.
Perhaps the code for the ipc renderer initialization could be extracted, as it is used at multiple places in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
every instance of "remote" got replaced with an ipcrenderer as remote is no longer supported i the newer versions of electron
Pre-merge TODOs and Checks