Add loading state on nested router #328
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simple loading to the RouteDefinition
How
For example:
{ path: "/:id", loading: Some(() => <StudentsLoading />), page: Some( (~dynamicParams, ~queryParams as _) => { let id = Router.DynamicParams.find("id", dynamicParams) |> Option.map(int_of_string); <StudentsPage id />; }, ), }