async: Fix discarded channel input data #37
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channel input was inadvertently being discarded because of an incorrect refcount comparison (wrong order of operations). This would cause data to be discarded if async progress() runs before the ChanIn has consumed data. In sunsetc this never seems to occur, maybe due to specifics how the Futures are executed by embassy_futures::select? In work in progress SFTP's demo, incoming data seems to be intermittently discarded. Fixes: f06f7ce ("Move channel wakers into core sunset crate")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel input was inadvertently being discarded because of an incorrect refcount comparison (wrong order of operations).
This would cause data to be discarded if async progress() runs before the ChanIn has consumed data. In sunsetc this never seems to occur, maybe due to specifics how the Futures are executed by embassy_futures::select?
In work in progress SFTP's demo, incoming data seems to be intermittently discarded.
Fixes: f06f7ce ("Move channel wakers into core sunset crate")