Add support for finding buttons that use aria-label for a value.

[bkosborne]

See #779

This adds support for finding a button by its aria-label value.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8527fd) 98.72% compared to head (98f712c) 98.73%.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #865   +/-   ##
=========================================
  Coverage     98.72%   98.73%           
  Complexity      374      374           
=========================================
  Files            24       24           
  Lines          1022     1024    +2     
=========================================
+ Hits           1009     1011    +2     
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maelanleborgne]

As it is very hard to extend the library, I would greatly appreciate if this feature was merged 🙂

[aik099]

As it is very hard to extend the library, I would greatly appreciate if this feature was merged 🙂

@maelanleborgne , can you please be more specific?

P.S.
I've approved this PR.

I've confirmed, that the tests actually test the added code by removing added HTML elements from the test fixtures one by one and witnessing, that tests start to fail after that.

// cc: @stof

[uuf6429]

Not bad, but aria-label applies to way more elements than just <button>. In particular, it should probably be implemented on '%linkMatch%' (similar to '%buttonMatch%').

[mlncn]

Thanks for approving— i think it is worth getting in as is, and future improvements (links as well as buttons, aria-labelledby) can build on it.