Skip to content

fix esp32 timer resolution #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sneakyaardvark wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix esp32 timer resolution #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2fbae1
Merge pull request #60 from midilab/develop
midilab Nov 8, 2025
6cf39cc
add breakchanges for v2.3+
midilab Nov 10, 2025
b397d4a
fix esp32 timer resolution
sneakyaardvark Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,16 +534,19 @@ void loop() {

⚠️ **Note**: Software timer mode provides less accurate timing than hardware interrupts.

## Migration Guide (v1.x → v2.0)
## Migration Guide (v1.x → v2.3)

### Breaking Changes

| Old API (v1.x) | New API (v2.0+) |
| Old API (v1.x) | New API (v2.3+) |
|----------------|-----------------|
| `setClock96PPQNOutput()` | `setOnOutputPPQN()` |
| `setClock16PPQNOutput()` | `setOnStep()` |
| `setOnClockStartOutput()` | `setOnClockStart()` |
| `setOnClockStopOutput()` | `setOnClockStop()` |
| `setOnSync24()` | `setOnSync(uClock.PPQN_24, onSync24)` |
| `setOnSync48()` | `setOnSync(uClock.PPQN_48, onSync48)` |
| `setOnSyncXX()` | `setOnSync(uClock.PPQN_XX, onSyncXX)` |

### Resolution Changes

Expand Down
4 changes: 2 additions & 2 deletions src/platforms/esp32-nofrertos.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ void ARDUINO_ISR_ATTR handlerISR(void)

void initTimer(uint32_t init_clock)
{
_uclockTimer = timerBegin(init_clock);
_uclockTimer = timerBegin(1000000);

// attach to generic uclock ISR
timerAttachInterrupt(_uclockTimer, &handlerISR);
Expand All @@ -29,4 +29,4 @@ void initTimer(uint32_t init_clock)
void setTimer(uint32_t us_interval)
{
timerAlarmWrite(_uclockTimer, us_interval, true);
}
}
4 changes: 2 additions & 2 deletions src/platforms/esp32.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void initTimer(uint32_t init_clock)
// create the clockTask
xTaskCreate(clockTask, "clockTask", CLOCK_STACK_SIZE, NULL, 1, &taskHandle);

_uclockTimer = timerBegin(init_clock);
_uclockTimer = timerBegin(1000000);

// attach to generic uclock ISR
timerAttachInterrupt(_uclockTimer, &handlerISR);
Expand All @@ -55,4 +55,4 @@ void initTimer(uint32_t init_clock)
void setTimer(uint32_t us_interval)
{
timerAlarm(_uclockTimer, us_interval, true, 0);
}
}