Fix race condition in undesired models state by making it observable #2402
+173
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_currentModelObsreads undesired models synchronously via_undesiredModelsManager.isUndesiredModelId(), but that state is updated asynchronously insetCurrentModelId. This causes stale reads when the observable recomputes before async updates complete.Changes
ISettableObservable<string[]>toUndesiredModels.Manager, exposed viamodelsObservablegetter_currentModelObsnow readsundesiredModelIdsfrom the observable_pickModel: AcceptsundesiredModelIds: string[]parameter instead of reading from managerThe observable updates after persisting to global state, ensuring the dependency chain recomputes with consistent data.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.