consomme: add udp timeout #2569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2025 14:55
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements idle timeout functionality for UDP connections in the consomme network device to prevent connection state leaks. The timeout defaults to 5 minutes per RFC 4787 and can be configured through ConsommeParams.
Key changes:
- Added configurable UDP connection timeout with RFC 4787-compliant default
- Implemented last activity tracking per UDP connection
- Added timeout checking logic during connection polling to remove stale connections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/net/net_consomme/consomme/src/udp.rs | Adds timeout parameter to Udp struct, tracks last_activity timestamp per connection, and implements timeout checking logic in poll_udp |
| vm/devices/net/net_consomme/consomme/src/lib.rs | Adds udp_timeout field to ConsommeParams with 5-minute default per RFC 4787 and passes timeout to Udp::new() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses one of the backlog items in #2313 regarding: leaking connection state.