-
Notifications
You must be signed in to change notification settings - Fork 5
Release - Lucia Training Platform v1.5 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix numa parsing in job exporter on GB200.
Fix kubespray deployment on bare metal when cffi package is installed by package manager.
Co-authored-by: Rui Gao <ruigao@microsoft.com>
Co-authored-by: Rui Gao <ruigao@microsoft.com> Co-authored-by: zhogu <57975490+zhogu@users.noreply.github.com>
* change trigger of github workflow * update * update * update
Co-authored-by: Rui Gao <ruigao@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Release PR to merge v1.5 fixes into dev, focusing on stability/circular-dependency resolution, deployment reliability, and job-exporter NUMA parsing correctness.
Changes:
- Break circular dependencies in rest-server by switching several imports to lazy
require()calls. - Fix NUMA parsing in job-exporter’s node exporter by skipping incomplete
numactl --hardwareCPU lines. - Update kubespray deployment scripts/requirements and adjust GitHub Actions workflow triggers for release/build pipelines.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rest-server/src/utils/manager/user/crudK8sSecret.js | Lazy-load job model to avoid circular dependency during user VC history retrieval. |
| src/rest-server/src/models/v2/storage.js | Lazy-load user model in list/get to avoid circular dependency. |
| src/rest-server/src/models/v2/job/k8s.js | Lazy-load user model in put to avoid circular dependency. |
| src/job-exporter/src/Moneo/src/worker/exporters/node_exporter.py | Improve NUMA CPU list parsing to avoid parsing empty cpus: lines. |
| docs/LuciaTrainingPlatform/blog/2026-02-06-release-1-5.md | Add v1.5.0 release notes blog post. |
| contrib/kubespray/script/requirements.txt | Add cffi pin for kubespray scripting environment. |
| contrib/kubespray/script/environment.sh | Remove python3-cffi alongside python3-cryptography to avoid pip/apt conflicts. |
| .github/workflows/build-deploy-changes.yaml | Remove push trigger; workflow now runs on PRs targeting main/dev/release/*. |
| .github/workflows/build-all.yaml | Adjust PR trigger types, default dispatch branch, and job gating condition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Merge bug fixes from v1.5 to dev branch.
Major Revisions