-
Notifications
You must be signed in to change notification settings - Fork 5
Update the workflow tigger #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refines GitHub Actions workflow triggers and job execution conditions to better control when builds and deployments occur. The changes ensure workflows only execute on merged pull requests or direct push events, and update the default branch for manual workflow dispatches.
Changes:
- Modified workflow triggers to respond to specific pull request events (opened/closed) rather than all PR activities
- Added job-level conditions to prevent execution on unmerged pull requests
- Changed the default branch for manual workflow dispatch from 'main' to 'dev' in build-all.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/build-deploy-changes.yaml | Added pull request type filters (opened, closed) and job condition to skip unmerged PRs |
| .github/workflows/build-all.yaml | Removed push trigger, changed to pull_request with closed type only, updated default branch to 'dev', and added job condition for merged PRs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates the GitHub Actions workflow triggers and job conditions for both the
build-all.yamlandbuild-deploy-changes.yamlworkflow files. The main goal is to refine when workflows are triggered and executed, especially in relation to pull request events, and to change the default branch for workflow runs.Workflow trigger and condition updates:
Workflow event triggers:
.github/workflows/build-all.yaml, the workflow is now triggered only when a pull request targeting arelease/*branch is closed, instead of on push events..github/workflows/build-deploy-changes.yaml, the workflow is now triggered when a pull request targetingmain,dev, orrelease/*branches is opened or closed, in addition to existing push events.Job execution conditions:
Default branch update:
branchinbuild-all.yamlhas been changed frommaintodev.