This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Support MinMaxAnalysisUtil.analyzeIndex API#521
Open
sezruby wants to merge 1 commit intomicrosoft:masterfrom
Open
Support MinMaxAnalysisUtil.analyzeIndex API#521sezruby wants to merge 1 commit intomicrosoft:masterfrom
sezruby wants to merge 1 commit intomicrosoft:masterfrom
Conversation
paryoja
reviewed
Jan 14, 2022
| val indexEntry = idxManager.getIndex(indexName, latestVer).get | ||
|
|
||
| if (!Seq("CoveringIndex", "ZOrderCoveringIndex").contains(indexEntry.derivedDataset.kind)) { | ||
| throw HyperspaceException(s"Does not support index type: ${indexEntry.derivedDataset.kind}") |
Contributor
There was a problem hiding this comment.
What if this is checked in the analyzeIndex? And is it possible to check supported index types more systemically?
If someone implement a new type of "CoveringIndex", it might be hard to come here to add it in the supported type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
Add MinMaxAnalysisUtil.analyzeIndex API to analyze min/max data layout of index data. It only supports covering index type.
This PR introduces the following API:
Without it, users may need to use a dummy filter query (like the following code) to check the index data and it's only for the selected index.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
via notebook