Conversation
andrei-ionescu
left a comment
There was a problem hiding this comment.
These methods being moved around will cause substantial conflicts in other PRs. Is this really necessary? Can we check what's the impact on the current opened PRs?
|
@andrei-ionescu All changes are from rearrangement and I think it looks no problem. Which change are you concerned? |
|
Hmm, I don't think we should enforce rearrangement with scalafmt since it is not consistent with other files. Can you please turn if off? When I run scalafmt on |
|
OK, I have turned it off. i guess it would be good to add a note about it to contribution guide. |
|
Thanks @dmytroDragan, will update the contribution guide. |
What is the context for this pull request?
What changes were proposed in this pull request?
Files (which were changed in #417) were missing scalafmt formatting.
As result PR-417 is hard to review due to mix of issue fix and scalafmt formatting.
To resolve it, the simplest approach is to apply scalafmt formatting in first place.
After merging this PR PR-417 should be unblocked.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need