Enable GODEBUG=fips140=only with systemcrypto backends#2149
Enable GODEBUG=fips140=only with systemcrypto backends#2149gdams wants to merge 5 commits intomicrosoft/mainfrom
Conversation
| + expectedAllocations := 0.0 | ||
| + if boring.Enabled { | ||
| + expectedAllocations = 2 | ||
| + expectedAllocations = 6 |
There was a problem hiding this comment.
@qmuntal I wanted you to sanity check this increase in allocations please :)
Patch Consistency Review - PR #2149I've completed a thorough review of the patch file changes in this PR. Here are my findings: ✅ Vendor Patch Consistency (0001-Vendor-external-dependencies.patch)The vendor patch properly updates all three backend dependencies:
Version updates:
✅ Cross-Backend ConsistencyThe changes add new FIPS 140-only mode support across backends:
✅ Backend Implementation Patch (0003-Implement-crypto-internal-backend.patch)
✅ Usage Patch (0004-Use-crypto-backends.patch)
📋 SummaryNo consistency issues found. The patches maintain proper cross-backend consistency while respecting backend-specific capabilities. The changes implement FIPS 140-only mode support (GODEBUG=fips140=only) in a well-structured manner across all three system crypto backends. The PR is ready from a patch consistency perspective. ✅
|
Fixes: #1656
Will need documentation before merging but pushing up the code changes for testing/review