Skip to content

Comments

implement s390x assembly for CGO-less#2143

Merged
gdams merged 2 commits intomicrosoft/mainfrom
dev/gadams/s390x
Feb 17, 2026
Merged

implement s390x assembly for CGO-less#2143
gdams merged 2 commits intomicrosoft/mainfrom
dev/gadams/s390x

Conversation

@gdams
Copy link
Member

@gdams gdams commented Feb 17, 2026

No description provided.

@gdams gdams requested a review from a team as a code owner February 17, 2026 11:20
@gdams gdams changed the base branch from dev/auto-sync/microsoft/main to microsoft/main February 17, 2026 11:48
@gdams gdams requested a review from qmuntal February 17, 2026 11:50
@github-actions
Copy link

✅ Patch Consistency Review - PASSED

I've completed a thorough review of the patch file changes in this PR. The implementation of s390x assembly for CGO-less OpenSSL support maintains excellent consistency across all patch files.

What was reviewed:

  1. Vendor patch consistency

    • All s390x assembly files correctly added to 0001-Vendor-external-dependencies.patch
    • go.mod version updated appropriately
    • Follows the same pattern as other architectures (arm64, ppc64le, riscv64)
  2. Cross-patch consistency

    • 0003-Implement-crypto-internal-backend.patch correctly updated to:
      • Add s390x to the test architecture list
      • Include s390x in the build tag exclusion list
      • Update documentation strings with s390x support
  3. Documentation consistency

    • eng/doc/NocgoOpenSSL.md updated with s390x support
    • Error messages updated to reflect the new architecture
  4. Pattern adherence

    • Changes follow the exact same pattern as previous architecture additions (riscv64, ppc64le)
    • No redundant patches or missing updates detected

Summary:

No consistency issues found. The PR properly maintains cross-patch consistency and follows established conventions. The s390x implementation is correctly split between the vendor patch (assembly implementations) and the crypto backend patch (build configuration and tests).

AI generated by Patch Consistency Review Agent

@gdams gdams merged commit d83b7c5 into microsoft/main Feb 17, 2026
49 checks passed
@gdams gdams deleted the dev/gadams/s390x branch February 17, 2026 12:45
@gdams gdams added the Area-Nocgo A label to track new architectures being requested in the OpenSSL cgo-less backend label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Nocgo A label to track new architectures being requested in the OpenSSL cgo-less backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants