Fix crash when HttpResponseDecoder receives non-JSON response #1405
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1338 where the application crashes when
HttpResponseDecoder::processBodyreceives a non-JSON HTTP response (e.g., HTML from captive portals or network sign-in pages).Changes
processBodymethodnlohmann::json::accept()to validate response body before attempting to parseProblem
When a network request returns a non-JSON response (such as HTML from a captive portal), the library attempts to parse it as JSON, causing a crash in the
nlohmann::json::parse()function.Solution
The fix adds a check using
nlohmann::json::accept()which safely validates whether the response body is valid JSON before attempting to parse it. If validation fails, the function logs an error and returns early.Testing
nlohmann::json::accept()method which is designed for safe validationFixes #1338