Skip to content

Conversation

@Andarist
Copy link
Contributor

fixes #62974

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 13, 2026
@Andarist Andarist marked this pull request as ready for review January 14, 2026 09:51
@RyanCavanaugh
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 14, 2026

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/62983/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"
  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,387 50,387 ~ ~ ~ p=1.000 n=6
Memory used 193,092k (± 0.75%) 193,745k (± 0.98%) ~ 192,447k 196,280k p=0.297 n=6
Parse Time 1.30s (± 0.97%) 1.29s (± 0.65%) ~ 1.29s 1.31s p=0.445 n=6
Bind Time 0.76s 0.76s ~ ~ ~ p=1.000 n=6
Check Time 9.87s (± 0.39%) 9.87s (± 0.31%) ~ 9.83s 9.92s p=0.871 n=6
Emit Time 2.75s (± 0.38%) 2.73s (± 0.44%) ~ 2.72s 2.75s p=0.084 n=6
Total Time 14.68s (± 0.22%) 14.66s (± 0.28%) ~ 14.62s 14.73s p=0.195 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 955,823 955,823 ~ ~ ~ p=1.000 n=6
Types 415,853 415,853 ~ ~ ~ p=1.000 n=6
Memory used 1,253,937k (± 0.00%) 1,253,911k (± 0.00%) ~ 1,253,847k 1,254,014k p=0.378 n=6
Parse Time 6.52s (± 0.64%) 6.56s (± 0.61%) ~ 6.51s 6.62s p=0.258 n=6
Bind Time 1.96s (± 0.43%) 1.96s (± 0.38%) ~ 1.95s 1.97s p=0.652 n=6
Check Time 32.38s (± 0.33%) 32.47s (± 0.30%) ~ 32.34s 32.60s p=0.127 n=6
Emit Time 14.98s (± 0.32%) 14.99s (± 0.34%) ~ 14.94s 15.08s p=0.688 n=6
Total Time 55.84s (± 0.23%) 55.97s (± 0.27%) ~ 55.75s 56.14s p=0.172 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,699,181 2,699,181 ~ ~ ~ p=1.000 n=6
Types 937,307 937,307 ~ ~ ~ p=1.000 n=6
Memory used 3,028,637k (± 0.00%) 3,028,579k (± 0.00%) ~ 3,028,498k 3,028,644k p=0.230 n=6
Parse Time 8.63s (± 0.46%) 8.62s (± 0.19%) ~ 8.60s 8.64s p=1.000 n=6
Bind Time 2.29s 2.29s (± 0.33%) ~ 2.28s 2.30s p=0.598 n=6
Check Time 93.78s (± 0.25%) 93.87s (± 0.28%) ~ 93.59s 94.31s p=0.748 n=6
Emit Time 0.31s 0.31s ~ ~ ~ p=1.000 n=6
Total Time 105.00s (± 0.22%) 105.09s (± 0.24%) ~ 104.79s 105.51s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,252,015 1,252,016 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,850 259,850 ~ ~ ~ p=1.000 n=6
Memory used 2,508,410k (±11.84%) 2,508,625k (±11.88%) ~ 2,386,640k 3,117,446k p=0.575 n=6
Parse Time 5.18s (± 0.88%) 5.19s (± 0.94%) ~ 5.15s 5.28s p=0.872 n=6
Bind Time 1.86s (± 1.30%) 1.86s (± 1.62%) ~ 1.81s 1.90s p=0.806 n=6
Check Time 35.56s (± 0.50%) 35.57s (± 0.47%) ~ 35.40s 35.87s p=0.575 n=6
Emit Time 3.00s (± 1.54%) 3.03s (± 2.15%) ~ 2.92s 3.12s p=0.471 n=6
Total Time 45.63s (± 0.44%) 45.64s (± 0.27%) ~ 45.48s 45.86s p=0.873 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,252,015 1,252,016 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,850 259,850 ~ ~ ~ p=1.000 n=6
Memory used 3,061,178k (± 9.65%) 3,182,505k (± 0.02%) ~ 3,181,652k 3,183,419k p=0.173 n=6
Parse Time 8.36s (± 1.55%) 8.44s (± 0.60%) ~ 8.37s 8.50s p=0.295 n=6
Bind Time 2.79s (± 1.60%) 2.76s (± 0.93%) ~ 2.72s 2.79s p=0.297 n=6
Check Time 53.18s (± 0.36%) 53.32s (± 0.14%) ~ 53.23s 53.39s p=0.066 n=6
Emit Time 4.33s (± 2.14%) 4.35s (± 1.94%) ~ 4.20s 4.44s p=0.810 n=6
Total Time 68.66s (± 0.46%) 68.89s (± 0.19%) ~ 68.67s 69.08s p=0.173 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 264,672 264,673 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,063 104,063 ~ ~ ~ p=1.000 n=6
Memory used 442,995k (± 0.02%) 443,063k (± 0.02%) ~ 442,856k 443,137k p=0.230 n=6
Parse Time 3.53s (± 0.91%) 3.52s (± 0.68%) ~ 3.48s 3.54s p=0.368 n=6
Bind Time 1.38s (± 0.99%) 1.39s (± 0.59%) ~ 1.38s 1.40s p=0.868 n=6
Check Time 19.22s (± 0.20%) 19.19s (± 0.25%) ~ 19.13s 19.27s p=0.286 n=6
Emit Time 1.54s (± 0.86%) 1.54s (± 1.46%) ~ 1.52s 1.58s p=1.000 n=6
Total Time 25.68s (± 0.26%) 25.64s (± 0.31%) ~ 25.57s 25.78s p=0.335 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 73 73 ~ ~ ~ p=1.000 n=6
Symbols 225,493 225,493 ~ ~ ~ p=1.000 n=6
Types 94,373 94,373 ~ ~ ~ p=1.000 n=6
Memory used 369,831k (± 0.02%) 369,869k (± 0.05%) ~ 369,770k 370,220k p=0.936 n=6
Parse Time 3.55s (± 1.03%) 3.52s (± 0.71%) ~ 3.48s 3.55s p=0.172 n=6
Bind Time 2.04s (± 0.96%) 2.04s (± 1.57%) ~ 2.01s 2.09s p=0.935 n=6
Check Time 20.62s (± 0.45%) 20.72s (± 0.45%) ~ 20.59s 20.83s p=0.149 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 26.22s (± 0.44%) 26.28s (± 0.42%) ~ 26.15s 26.42s p=0.423 n=6
vscode - node (v18.15.0, x64)
Errors 11 11 ~ ~ ~ p=1.000 n=6
Symbols 4,107,898 4,107,898 ~ ~ ~ p=1.000 n=6
Types 1,299,167 1,299,167 ~ ~ ~ p=1.000 n=6
Memory used 3,901,470k (± 0.00%) 3,901,411k (± 0.00%) ~ 3,901,345k 3,901,486k p=0.810 n=6
Parse Time 19.53s (± 1.28%) 19.62s (± 0.50%) ~ 19.46s 19.72s p=0.810 n=6
Bind Time 6.98s (±13.07%) 6.57s (± 0.64%) ~ 6.50s 6.62s p=0.873 n=6
Check Time 136.96s (± 3.47%) 138.07s (± 2.02%) ~ 135.69s 142.18s p=0.471 n=6
Emit Time 54.91s (±13.60%) 50.58s (±15.91%) ~ 46.93s 67.02s p=0.128 n=6
Total Time 218.38s (± 4.81%) 214.85s (± 4.52%) ~ 208.97s 233.84s p=0.575 n=6
webpack - node (v18.15.0, x64)
Errors 41 41 ~ ~ ~ p=1.000 n=6
Symbols 384,170 384,170 ~ ~ ~ p=1.000 n=6
Types 168,308 168,308 ~ ~ ~ p=1.000 n=6
Memory used 543,305k (± 0.03%) 543,462k (± 0.04%) ~ 543,179k 543,660k p=0.128 n=6
Parse Time 4.70s (± 0.35%) 4.71s (± 0.42%) ~ 4.69s 4.74s p=0.139 n=6
Bind Time 2.02s (± 1.02%) 2.00s (± 0.80%) ~ 1.98s 2.02s p=0.052 n=6
Check Time 23.81s (± 1.50%) 23.54s (± 1.04%) ~ 23.35s 24.02s p=0.336 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.53s (± 1.22%) 30.25s (± 0.86%) ~ 30.09s 30.77s p=0.575 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 696,322 696,322 ~ ~ ~ p=1.000 n=6
Types 212,496 212,496 ~ ~ ~ p=1.000 n=6
Memory used 590,963k (± 0.02%) 591,151k (± 0.02%) +188k (+ 0.03%) 590,931k 591,259k p=0.045 n=6
Parse Time 4.14s (± 0.37%) 4.15s (± 0.74%) ~ 4.12s 4.20s p=0.805 n=6
Bind Time 1.41s (± 1.47%) 1.40s (± 1.17%) ~ 1.38s 1.42s p=0.511 n=6
Check Time 21.52s (± 1.56%) 21.07s (± 1.55%) ~ 20.82s 21.71s p=0.054 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 27.07s (± 1.28%) 26.62s (± 1.19%) ~ 26.33s 27.22s p=0.077 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62983/merge:

Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

3 participants