Skip to content

Conversation

@PozzettiAndrea
Copy link

The 'd' suffix on double literals (e.g., 1e-6d, 0.0d) is a GCC extension that MSVC does not support. Use standard C++ double literals instead.

File changed: src/convert/flexible_dual_grid.cpp

The 'd' suffix on double literals (e.g., 1e-6d, 0.0d) is a GCC extension
that MSVC does not support. Use standard C++ double literals instead.

File changed: src/convert/flexible_dual_grid.cpp
@Deathdadev
Copy link

Deathdadev commented Dec 29, 2025

While these changes (including #61, #60, #59) correctly resolve issues for Windows users, they introduce breaking changes for Linux environments.

These PRs port Linux syntax specifically to Windows, similar to approaches taken in other forks (See #4 for information, Deathdadev/TRELLIS.2-Windows (my own fork), visualbruno/ComfyUI-Trellis2).

Since this repository is tested and designed for Linux, we cannot simply replace the syntax. Instead, we need to implement cross-platform logic to ensure the code runs correctly on both systems.

Edit:
Apologies, #61 is unrelated to Linux syntax

@PozzettiAndrea
Copy link
Author

@Deathdadev I'm all for cross-platform logic! :)

I don't think my changes introduce any breaking changes for Linux though:

These changes move the codebase toward standard C++, to my understanding they don't use "Windows syntax"
Please let me know if you see any specific issue!

@Deathdadev
Copy link

@PozzettiAndrea Sorry about that, I almost completely forgot about standard C++ altogether! I did some trial and error just now in case there was something I could pick up on, and you are correct.

Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants