Ensure host disposal in BuildStatelessWebService_RegisterListeners test#828
Merged
neilr81 merged 2 commits intobugfix/pu-feb07-26from Feb 11, 2026
Merged
Ensure host disposal in BuildStatelessWebService_RegisterListeners test#828neilr81 merged 2 commits intobugfix/pu-feb07-26from
neilr81 merged 2 commits intobugfix/pu-feb07-26from
Conversation
Co-authored-by: K-Cully <2370032+K-Cully@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on package versions in Directory.Packages.props
Ensure host disposal in BuildStatelessWebService_RegisterListeners test
Feb 11, 2026
neilr81
approved these changes
Feb 11, 2026
neilr81
added a commit
that referenced
this pull request
Feb 11, 2026
* Update package versions in Directory.Packages.props Updated package versions for various dependencies including Microsoft.ServiceFabric and MSTest packages. * Update Directory.Packages.props with new XML format * Update Service Fabric version in build workflow * Update default SdkVersion to 11.3.475.1 * Prevent host start in listener registration test Comment out host start and address assertions to prevent CI failures related to socket access permissions. * Remove StopAsync call in HostBuilderExtensionsTests Removed unnecessary call to StopAsync in the test. * Ensure host disposal in BuildStatelessWebService_RegisterListeners test (#828) * Initial plan * Wrap host creation in using statement to ensure disposal Co-authored-by: K-Cully <2370032+K-Cully@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: K-Cully <2370032+K-Cully@users.noreply.github.com> * Update Directory.Packages.props * Update SDK version to 10.0.103 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: K-Cully <2370032+K-Cully@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses resource leak in test that creates but doesn't start an
IHost. Even unstarted hosts hold disposable resources (service provider, singletons).Changes
IHostcreation inusingstatement to ensure disposal at method exit✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.