Skip to content

Bann save load one file Test PR #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jinwei14 wants to merge 40 commits into
base: cpp_main
Choose a base branch
from
Open

Bann save load one file Test PR #678

jinwei14 wants to merge 40 commits into from

Conversation

@jinwei14
Copy link
Contributor

@jinwei14 jinwei14 commented Oct 13, 2025

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

NingyuanChen and others added 30 commits January 8, 2024 13:20
@NingyuanChen
Initial change for save/load as one file. (#504)
ee62d8d 
Co-authored-by: REDMOND\ninchen <ninchen@microsoft.com>
BANN single file Save and Load.
df84a6d
Fix Save One file bugs.
4467272
@ltan1ms
add a get_num_deleted_points method
dbd702b
@ltan1ms
in-mem graph loading: skip reading neighbor list when out edge count …
8e4d10d 
…is 0
@hliu18
add wait() method to AlignedFileReader
e426e8e
@NingyuanChen
Fix the wrong behavior when saving tags without calling any lazy_dele…
1de7ac4 
…te. (#519)

* Fix the wrong behavior when saving tags without calling any lazy_delete.

* Add option to force compact_data.

---------

Co-authored-by: REDMOND\ninchen <ninchen@microsoft.com>
@ltan1ms
Remove unnecessary tag 0 check when insertion. Fix max_points during …
bc7568e 
…initialization (same a PR 523)
@hliu18
replace callback with Wait() method
27af2dd
@hliu18
replace callback driven wait with new Wait() method
79f83c1
@ltan1ms
fix merge conflict with 79f83c1
e1d4235
@ltan1ms
allow build as static lib
abefd07
@ltan1ms
add a size check in is_in_set method to avoid assert error in debug b…
987db19 
…uild
@ltan1ms
DLVS only: allow update vector for tag and record deleted tags
9ca8ac9
@ltan1ms
fix one uncommented line in CMakeLists.txt
b20d668
@ltan1ms
remove dllmain.cpp from building
270dfd8
@ltan1ms
enable capacity expanding
502eb04
@hliu18
wait on completeCount if callback is used
facfc28
@MS-Renan
merging multifilter for bann (#543)
9c8e88d
@MS-Renan
Fix for getNextCompletedRequest (#548)
39a2005 
* readd skip wait if callback is not present

* Delete AnyBuildLogs/latest.txt

* Update pq_flash_index.cpp
@MS-Renan
560 bug remove unused line (#561)
7e9c3f4 
* remove unused line

* remove old code

* remove other unused line
@gopal-msr
Fixes to utility functions and apps to support multi-filter queries
5473656
@gopal-msr
Merge branch 'BANN_save_load_one_file' of https://github.com/microsof…
4871688 
…t/DiskANN into BANN_save_load_one_file
@gopal-msr
Set sector scratch to max of (maxdegree,max_filters_per_query,max_sec…
e94b9a8 
…tor_reads)
@gopal-msr
Adding correct #ifdef EXEC_ENV_OLS blocks
07f21f3
@gopal-msr
Fixing more EXEC_ENV_OLS
b2b0942
@gopal-msr
Adding cosine support in build_disk_index and ensuring that the dummy…
74ce806 
… map file is written in the correct location
@gopal-msr
Creating version of DiskANN dll for build with dependency on tcmalloc
98141ce
@gopal-msr
Delete the mem index file and sample files
96e1751
@ltan1ms
Use much smaller scratch space for non filter case (#639)
da7416a 
* Use much smaller scratch space for non filter case

* fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jinwei14 @MS-Renan @NingyuanChen @ltan1ms @hliu18 @gopal-msr @amrmorsey @jwz14