DRAFT: Test/simplify transformation tests#749
Open
raivo-otus wants to merge 14 commits intomicrobiome:develfrom
Open
DRAFT: Test/simplify transformation tests#749raivo-otus wants to merge 14 commits intomicrobiome:develfrom
raivo-otus wants to merge 14 commits intomicrobiome:develfrom
Conversation
TuomasBorman
requested changes
Jul 28, 2025
Contributor
TuomasBorman
left a comment
TuomasBorman
left a comment
There was a problem hiding this comment.
Great, thanks! See comments
TuomasBorman
reviewed
Dec 8, 2025
Contributor
TuomasBorman
left a comment
TuomasBorman
left a comment
There was a problem hiding this comment.
This does right things but only for small part of tests. For those transformations that come from vegan, only one test is needed, i.e., test that checks that transformAssay equals to vegan::decostand (test that mia do not introduce errors when calling the function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing mia unit tests. Related issue #748
Opening a draft PR to receive ongoing feedback to confirm correct direction/intent.