print output on the same line if output is a terminal

[E5ten]

can be manually enabled or disabled at build time by defining
HAVE_TIOCGWINSZ in CFLAGS, otherwise automatically disabled on
operating systems known to have the TIOCGWINSZ ioctl

[E5ten]

I think I've resolved the issue I tried to solve the wrong way in #44.

[michaelforney]

Do you think you could come up with a small abstraction for the status printing? Then the smart status printer could go into a separate file, and we avoid all the ifdefs.

Maybe something like statusinit(), statusprint(const char *status, const char *description), statusoutput(const char *out, size_t len), statusdone()?

Actually, now that I think about it, it might be simpler to just have a single function size_t termwidth(void). term-dumb.c could just return 0, and term-ansi.c could use the ioctl.

[E5ten]

Do you think you could come up with a small abstraction for the status printing? Then the smart status printer could go into a separate file, and we avoid all the ifdefs.

Maybe something like statusinit(), statusprint(const char *status, const char *description), statusoutput(const char *out, size_t len), statusdone()?

Actually, now that I think about it, it might be simpler to just have a single function size_t termwidth(void). term-dumb.c could just return 0, and term-ansi.c could use the ioctl.

What would I do to have the build choose which of term-{dumb,ansi}.c to use?

[michaelforney]

What would I do to have the build choose which of term-{dumb,ansi}.c to use?

I'd just do

TERM=dumb
OBJ=\
	...
	term-$(TERM).o

Operating systems that want to enable smart status printing can just build with make TERM=ansi.

[E5ten]

And should I add a header, or forward declare any functions from term-{dumb,ansi}.c in build.c?

[michaelforney]

Yeah, a term.h is probably appropriate.

[E5ten]

This will probably need at least some cleanup but I've moved the ifdefed stuff into separate files.

[michaelforney]

Thanks, this is looking pretty good now.

[E5ten]

Is there anything still blocking this?

[bonzini]

Honestly I think printing all output on the same line is a bad idea and (the lack of) this is the main reason why I use samu instead of ninja. Since ninja has no "whatif" tool which is the opposite of "commands", that is to print what would be built if a file was touched, the only way to do so is to touch the source file and do a ninja -n. But ninja -n effectively only prints the last line, so you have to do ninja -n | cat... or just use samu instead.

[E5ten]

This is a build-time option that defaults to being disabled, so I don't think that's really a problem