Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program Instruction Changes
futarchy
initialize_dao/update_dao— new DAO invariant checks reject zero valuesThree new invariant checks are enforced. Any
initialize_daoorupdate_daocall that sets any of these to0will now fail:min_base_futarchic_liquidity > 0min_quote_futarchic_liquidity > 0twap_max_observation_change_per_update > 0launch_proposal— rejects zero reservesNew
require_gt!checks onbase_to_lpandquote_to_lp. A proposal whose spot pool has insufficient reserves (resulting in zero after halving) will now fail to launch.provide_liquidity— rejects zero base amountNew
require_gt!(max_base_amount, 0)check. Calls withmax_base_amount = 0will now fail.v06_launchpad
complete_launch— DAO created with non-zero min futarchic liquiditymin_quote_futarchic_liquidityandmin_base_futarchic_liquiditychanged from0to1. DAOs created by this instruction will have stricter invariants than before.v07_launchpad
complete_launch— same change as v06_launchpadmin_quote_futarchic_liquidityandmin_base_futarchic_liquiditychanged from0to1.Additional notes
Daoaccount boxed inCollectFees,UpdateDao,WithdrawLiquidity— Rust memory optimization only, no wire format or IDL changefinalize_proposalsafe cast (as i16→i16::try_from()) — unreachable in practice due toMAX_PASS_THRESHOLD_BPS = 1_000invariant