fix optimizer storage breakdown planner stats logging always 0-valued #3616
+67
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - refactor EmbOptimType to OptimizerClass mapping and generate functions to access forward/backward mapping - fix optimizer storage clculation by instead using sharder's `fused_params["optimizer"]` (EmbOptimType) when tensor attribute unavailable - add `_emb_opt_type_to_optimizer_class` helper to convert EmbOptimType back to optimizer class for storage calculation Differential Revision: D88532615
meta-cla
bot
added
the
CLA Signed
Contributor
|
@ashuaibi7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88532615. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fused_params["optimizer"](EmbOptimType) when tensor attribute unavailable_emb_opt_type_to_optimizer_classhelper to convert EmbOptimType back to optimizer class for storage calculationDifferential Revision: D88532615