: config: make all configuration variables available to configure #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89560177. |
…tencies (meta-pytorch#2182) Summary: key change here is precedence: Env wins over ClientOverride. everything else is cleanup to make the code and docs say the same thing and to reduce the chance we "remember" the wrong order later. tests are updated to encode the new behavior. Reviewed By: mariusae Differential Revision: D89551496
Summary: fill in a few missing tests Reviewed By: colin2328 Differential Revision: D89553139
…ytorch#2184) Summary: this adds python-side config support for a couple of additional rust types. specifically, it introduces `PyEncoding` to bridge string values onto `hyperactor::data::Encoding`, and `PyPortRange` to bridge python `(start, end)` tuples or `"start..end"` strings onto `Range<u16>`. both are wired into `declare_py_config_type!` so they work with `monarch.configure(...)`, and the new tests cover parsing, validation, and round-tripping for the supported formats. Differential Revision: D89555029
Summary: this wires a bunch of previously env-only `CONFIG` keys through the python configure path by giving them `py_name`s, updating the python wrapper + stubs to surface everything explicitly. the tests are expanded to systematically cover the new parameters (defaults, set/restore behavior, and basic type error cases), plus validation for encodings and port-range parsing. Differential Revision: D89560177
shayne-fletcher
force-pushed
the
export-D89560177
branch
from
38f098e to
062e4b1
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Dec 19, 2025
…ta-pytorch#2186) Summary: this wires a bunch of previously env-only `CONFIG` keys through the python configure path by giving them `py_name`s, updating the python wrapper + stubs to surface everything explicitly. the tests are expanded to systematically cover the new parameters (defaults, set/restore behavior, and basic type error cases), plus validation for encodings and port-range parsing. Differential Revision: D89560177
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Dec 19, 2025
…ta-pytorch#2186) Summary: this wires a bunch of previously env-only `CONFIG` keys through the python configure path by giving them `py_name`s, updating the python wrapper + stubs to surface everything explicitly. the tests are expanded to systematically cover the new parameters (defaults, set/restore behavior, and basic type error cases), plus validation for encodings and port-range parsing. Differential Revision: D89560177
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Dec 19, 2025
…ta-pytorch#2186) Summary: this wires a bunch of previously env-only `CONFIG` keys through the python configure path by giving them `py_name`s, updating the python wrapper + stubs to surface everything explicitly. the tests are expanded to systematically cover the new parameters (defaults, set/restore behavior, and basic type error cases), plus validation for encodings and port-range parsing. Differential Revision: D89560177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D89560177